xiangfu0 commented on code in PR #11495:
URL: https://github.com/apache/pinot/pull/11495#discussion_r1315102321
##########
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java:
##########
@@ -186,17 +186,9 @@ private static Expression
rewriteEqualsExpression(Expression equals, FilterKind
}
break;
}
- case FLOAT: {
- float converted = (float) actual;
- if (converted != actual) {
- // Double to float conversion is lossy.
- return getExpressionFromBoolean(result);
- } else {
- // Replace double value with converted float value.
- rhs.getLiteral().setDoubleValue(converted);
- }
+ case FLOAT:
Review Comment:
then this case branch is not needed as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
