gortiz opened a new pull request, #11512:
URL: https://github.com/apache/pinot/pull/11512

   This PR fixes an error I detected while trying to run all integration tests 
with V2. It seems that some queries are translated in V2 using SqlKind.SEARCH. 
We added partial support for that when implementing IN (for example in 
https://github.com/apache/pinot/pull/9374) but that was limited to cases where 
`SEARCH` used literals (like in `IN` expressions). 
   
   I've tried to exercise my code with more tests, but I wasn't able to create 
SQL queries that were translated into SqlKind.SEARCH. Therefore I've just 
modified the original test to run in both V1 and V2. It seems the kind of 
queries that are translated into this pattern are things like:
   ```sql
   SELECT ArrDelay > 50 OR ArrDelay < 10 FROM mytable
   ```
   
   but not queries like:
   ```sql
   SELECT 1 FROM mytable where ArrDelay > 50 OR ArrDelay < 10 LIMIT 1000
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to