This is an automated email from the ASF dual-hosted git repository.
atri pushed a commit to branch pluggable_store
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/pluggable_store by this push:
new faf647939a Fix recursion issue
faf647939a is described below
commit faf647939af31ac5020a91cf7e52c65f8819d708
Author: Atri Sharma <[email protected]>
AuthorDate: Tue Sep 5 23:39:39 2023 +0530
Fix recursion issue
---
.../segment/local/upsert/BasePartitionUpsertMetadataManager.java | 4 +++-
.../local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java | 2 +-
.../org/apache/pinot/segment/local/upsert/IntelligentKVStore.java | 3 +++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
index b11d04b73e..c2b5a8c8d0 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
@@ -704,7 +704,7 @@ public abstract class BasePartitionUpsertMetadataManager
implements PartitionUps
startOperation();
try {
- transferKeysBetweenPrimaryAndSecondaryStorage();
+ doTransferColdKeysToOffheapStorage();
} finally {
finishOperation();
}
@@ -715,6 +715,8 @@ public abstract class BasePartitionUpsertMetadataManager
implements PartitionUps
*/
protected abstract void doRemoveExpiredPrimaryKeys();
+ protected abstract void doTransferColdKeysToOffheapStorage();
+
@Override
public void stop() {
_stopped = true;
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
index 1d7cdbb395..96e82b64ca 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
@@ -237,7 +237,7 @@ public class ConcurrentMapPartitionUpsertMetadataManager
extends BasePartitionUp
}
@Override
- public void transferKeysBetweenPrimaryAndSecondaryStorage() {
+ public void doTransferColdKeysToOffheapStorage() {
//TODO: Declare own TTL
double threshold = _largestSeenComparisonValue - _metadataTTL;
_primaryKeyToRecordLocationMap.forEach((primaryKey, recordLocation) -> {
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/IntelligentKVStore.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/IntelligentKVStore.java
index 0f2434b7a1..35794a58d5 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/IntelligentKVStore.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/IntelligentKVStore.java
@@ -8,6 +8,9 @@ import java.util.function.BiConsumer;
import java.util.function.BiFunction;
+/**
+ *
+ */
public class IntelligentKVStore {
@VisibleForTesting
final ConcurrentHashMap<Object,
ConcurrentMapPartitionUpsertMetadataManager.RecordLocation>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
