This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5ed8fb01ee Ensure dataStream is cleaned up even when offsetStream
cleanup fails. (#11490)
5ed8fb01ee is described below
commit 5ed8fb01ee96bf10de224fcd93c3be21a7bf38c2
Author: swaminathanmanish <[email protected]>
AuthorDate: Tue Sep 5 12:00:39 2023 -0700
Ensure dataStream is cleaned up even when offsetStream cleanup fails.
(#11490)
---
.../core/segment/processing/genericrow/GenericRowFileWriter.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java
b/pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java
index 4f7957c349..171488f963 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java
@@ -66,7 +66,11 @@ public class GenericRowFileWriter implements Closeable {
@Override
public void close()
throws IOException {
- _offsetStream.close();
- _dataStream.close();
+ try {
+ // Wrapping around try block to make sure dataStream is closed, despite
failures while closing offsetStream.
+ _offsetStream.close();
+ } finally {
+ _dataStream.close();
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
