jadami10 commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1316462917
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -212,6 +225,59 @@ protected void doShutdown() {
if (_leaseExtender != null) {
_leaseExtender.shutDown();
}
+ // Make sure we do metric cleanup when we shut down the table.
+ _ingestionDelayTracker.shutdown();
Review Comment:
Sorry, forgot to respond with testing results. I was thinking it should be
done at the top of the function before the segment data managers are destroyed.
But I tested that, and I still saw lag when servers were shutting down. I've
since pivoted to tackling some other ingestion lag issues around losing
controllers, but I'll update once I get a chance to come back to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
