cyrilou242 commented on PR #11510: URL: https://github.com/apache/pinot/pull/11510#issuecomment-1708031674
Hey @abhioncbr I'm not sure this is a good approach in terms of maintainability: - this makes the pom very complex - dependencies in `common` and `core` may change. I fear clients exclusion will not be updated accordingly - clients developer may be tempted to use classes of the `common` and `core` package that won't work at runtime because some dependencies will have been excluded I'm not a maintainer of pinot so I don't have a strong opinion but I think it'd be better to first discuss potential solutions in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
