chenboat commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1320443889
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentCompletionUtils.java:
##########
@@ -42,6 +43,19 @@ public static String getSegmentNamePrefix(String
segmentName) {
}
public static String generateSegmentFileName(String segmentNameStr) {
Review Comment:
should we call it generateTempSegmentFileName instead since the file name is
for a tmp one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]