tibrewalpratik17 commented on code in PR #11330:
URL: https://github.com/apache/pinot/pull/11330#discussion_r1322951203
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -290,4 +302,52 @@ public static Map<String, String>
getOptionsFromJson(JsonNode request, String op
public static Map<String, String> getOptionsFromString(String optionStr) {
return
Splitter.on(';').omitEmptyStrings().trimResults().withKeyValueSeparator('=').split(optionStr);
}
+
+ public static Set<String> getTableNames(SqlNode sqlNode) {
Review Comment:
@xiangfu0 i think the major cause of removing this was maintaining the
overhead of maintaining this function as we kept on finding edge cases where we
were not extracting table names out. Though I see we are pushing to a random
broker now so should be good. cc @walterddr what are your thoughts on bringing
this method back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
