jasperjiaguo commented on PR #11496:
URL: https://github.com/apache/pinot/pull/11496#issuecomment-1716347496

   > Sorry for starting a new thread here, but while we are trying to "handle" 
OOM by resetting the netty channels, queries may still fail (I think). So, 
System.exit can be called instead, which will trigger the shutdown hook to 
shutdown the broker. This approach is simpler and has less unknowns. I am not a 
netty expert, hence this proposal is biased to keep it simple.
   
   Hey @soumitra-st 
   > OOM by resetting the netty channels, queries may still fail (I think)
   
   Only the queries that overlaps with the OOM event fails (inevitably). After 
the OOM is handled (pretty fast), all subsequent queries succeeds. I have 
tested this repeatitively on our perf cluster.
   
   > So, System.exit can be called instead, which will trigger the shutdown 
hook to shutdown the broker.
   
   This approach takes much less time than a broker restart, especially for 
larger clusters. 
   
   > has less unknowns
   
   Could you eleborate your concern here? I think the tests/heap dump/graphs 
show that we recover deterministically and the direct buffers are deallocated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to