gortiz commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1325568519


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java:
##########
@@ -74,10 +80,12 @@ public QueryServer(int port, NettyConfig nettyConfig, 
ChannelHandler instanceReq
    * @param nettyConfig configurations for netty library
    * @param tlsConfig TLS/SSL config
    */
-  public QueryServer(int port, NettyConfig nettyConfig, TlsConfig tlsConfig, 
ChannelHandler instanceRequestHandler) {
+  public QueryServer(int port, NettyConfig nettyConfig, TlsConfig tlsConfig, 
ChannelHandler instanceRequestHandler,
+      ServerMetrics serverMetrics) {

Review Comment:
   I didn't know we had that _feature_. I think it is a bad pattern and we 
should try to migrate to some kind of DI, but meanwhile it is our pattern, so 
I'll change the code to use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to