walterddr commented on code in PR #11607:
URL: https://github.com/apache/pinot/pull/11607#discussion_r1329106373
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/block/DataBlockValSet.java:
##########
@@ -36,29 +36,28 @@
* TODO: Support MV
*/
public class DataBlockValSet implements BlockValSet {
- protected final FieldSpec.DataType _dataType;
- protected final DataBlock _dataBlock;
- protected final int _index;
- protected final RoaringBitmap _nullBitMap;
+ private final DataType _dataType;
Review Comment:
i knew that DataBlock is a v2 concept. but other than that any specific
reason we put these in the runtime module and the RowBasedBlockValSet in the
core module? (i see DataBlock is still in core, imo might be eaiser to put
everything together)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
