xiangfu0 commented on code in PR #11621:
URL: https://github.com/apache/pinot/pull/11621#discussion_r1329796739
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -379,87 +377,15 @@ private String listTableConfigs(String tableName,
@Nullable String tableTypeStr)
@ManualAuthorization
@Path("/tables/{tableName}")
@ApiOperation(value = "Lists the table configs")
- public String alterTableStateOrListTableConfig(
+ public String listTableConfig(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "enable|disable|drop") @QueryParam("state") String
stateStr,
@ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr, @Context HttpHeaders httpHeaders,
@Context Request request) {
- try {
- if (StringUtils.isBlank(stateStr)) {
Review Comment:
Shall we still keep `@ApiParam(value = "enable|disable|drop")
@QueryParam("state") String stateStr,` but instead throw exception of
unsupported?
This is to avoid silent failure for existing users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
