walterddr commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1332130606
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java:
##########
@@ -94,24 +92,24 @@ public <T, C> T visit(PlanNodeVisitor<T, C> visitor, C
context) {
public static class JoinKeys {
@ProtoProperties
- private KeySelector<Object[], Object[]> _leftJoinKeySelector;
+ private List<Integer> _leftKeys;
@ProtoProperties
- private KeySelector<Object[], Object[]> _rightJoinKeySelector;
+ private List<Integer> _rightKeys;
Review Comment:
superb refactoring. this was a legacy property we added for pluggability
that we never used. we should've removed these and use factory methods even
before the 1.0 release :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
