walterddr commented on code in PR #11624:
URL: https://github.com/apache/pinot/pull/11624#discussion_r1333310198
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -465,4 +471,12 @@ public String sendRequestRaw(String url, String query,
ObjectNode requestJson, M
throw new AssertionError("Should not reach this");
}
}
+
+ private static String constructQueryExceptionResponse(ProcessingException
pe) {
+ try {
+ return new BrokerResponseNative(pe).toJsonString();
+ } catch (IOException ioe) {
+ throw new AssertionError("Should not reach this");
Review Comment:
yeah Utils rethrow should be the best. although it should never reach here
anyway b/c the constructed response will always be a valid json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
