klsince commented on code in PR #11628:
URL: https://github.com/apache/pinot/pull/11628#discussion_r1333575669
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java:
##########
@@ -335,7 +335,7 @@ private void processNewSegment(String tableNameWithType,
SegmentMetadata segment
}
try {
- _pinotHelixResourceManager.assignTableSegment(tableNameWithType,
segmentMetadata.getName());
+ _pinotHelixResourceManager.assignTableSegment(tableNameWithType,
segmentMetadata.getName(), _controllerMetrics);
Review Comment:
looks like _pinotHelixResourceManager is initialized (as part of init()
method), before _controllerMetrics (as part of start() method), I'll see if
that can be reordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
