walterddr commented on code in PR #11652:
URL: https://github.com/apache/pinot/pull/11652#discussion_r1333685451
##########
pinot-tools/src/main/resources/examples/stream/pullRequestMergedEvents/pullRequestMergedEvents_realtime_table_config.json:
##########
@@ -1,32 +1,34 @@
{
"tableName": "pullRequestMergedEvents",
"tableType": "REALTIME",
+ "tenants": {},
"segmentsConfig": {
"timeColumnName": "mergedTimeMillis",
"retentionTimeUnit": "DAYS",
"retentionTimeValue": "60",
- "schemaName": "pullRequestMergedEvents",
- "replication": "1",
- "replicasPerPartition": "1"
+ "replication": "1"
},
- "tenants": {},
"tableIndexConfig": {
- "loadMode": "MMAP",
"invertedIndexColumns": [
"organization",
"repo"
- ],
- "streamConfigs": {
- "streamType": "kafka",
- "stream.kafka.consumer.type": "simple",
- "stream.kafka.topic.name": "pullRequestMergedEvents",
- "stream.kafka.decoder.class.name":
"org.apache.pinot.plugin.stream.kafka.KafkaJSONMessageDecoder",
- "stream.kafka.consumer.factory.class.name":
"org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory",
- "stream.kafka.zk.broker.url": "localhost:2191/kafka",
- "stream.kafka.broker.list": "localhost:19092",
- "realtime.segment.flush.threshold.time": "12h",
- "realtime.segment.flush.threshold.size": "100000",
- "stream.kafka.consumer.prop.auto.offset.reset": "smallest"
+ ]
+ },
+ "ingestionConfig": {
+ "streamIngestionConfig": {
+ "streamConfigMaps": [
+ {
+ "streamType": "kafka",
+ "stream.kafka.topic.name": "pullRequestMergedEvents",
+ "stream.kafka.decoder.class.name":
"org.apache.pinot.plugin.stream.kafka.KafkaJSONMessageDecoder",
+ "stream.kafka.consumer.factory.class.name":
"org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory",
+ "stream.kafka.consumer.prop.auto.offset.reset": "smallest",
+ "stream.kafka.zk.broker.url": "localhost:2191/kafka",
+ "stream.kafka.broker.list": "localhost:19092",
+ "realtime.segment.flush.threshold.time": "12h",
+ "realtime.segment.flush.threshold.size": "100000"
+ }
+ ]
Review Comment:
any reason why the kafka version doesn't have the derived transformConfigs
columns?
either make the consistent or keep a "json" name in the filename like the
upsert side table config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
