This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4964a56631 Clean up
CaseTransformFunction::constructStatementListLegacy. (#11339)
4964a56631 is described below
commit 4964a566312d2da686f869a097859fe41de70d2d
Author: Shen Yu <[email protected]>
AuthorDate: Sun Sep 24 18:20:25 2023 -0700
Clean up CaseTransformFunction::constructStatementListLegacy. (#11339)
---
.../transform/function/CaseTransformFunction.java | 34 ----------------------
1 file changed, 34 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
b/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
index 1adb1312b8..19fa66db5c 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
@@ -88,25 +88,6 @@ public class CaseTransformFunction extends
ComputeDifferentlyWhenNullHandlingEna
}
private void constructStatementList(List<TransformFunction> arguments) {
- int numWhenStatements = arguments.size() / 2;
- boolean allBooleanFirstHalf = true;
- boolean notAllBooleanOddHalf = false;
- for (int i = 0; i < numWhenStatements; i++) {
- if (arguments.get(i).getResultMetadata().getDataType() !=
DataType.BOOLEAN) {
- allBooleanFirstHalf = false;
- }
- if (arguments.get(i * 2).getResultMetadata().getDataType() !=
DataType.BOOLEAN) {
- notAllBooleanOddHalf = true;
- }
- }
- if (allBooleanFirstHalf && notAllBooleanOddHalf) {
- constructStatementListLegacy(arguments);
- } else {
- constructStatementListCalcite(arguments);
- }
- }
-
- private void constructStatementListCalcite(List<TransformFunction>
arguments) {
int numWhenStatements = arguments.size() / 2;
// alternating WHEN and THEN clause, last one ELSE
for (int i = 0; i < numWhenStatements; i++) {
@@ -118,21 +99,6 @@ public class CaseTransformFunction extends
ComputeDifferentlyWhenNullHandlingEna
}
}
- // TODO: Legacy format, this is here for backward compatibility support,
remove after release 0.12
- private void constructStatementListLegacy(List<TransformFunction> arguments)
{
- int numWhenStatements = arguments.size() / 2;
- // first half WHEN, second half THEN, last one ELSE
- for (int i = 0; i < numWhenStatements; i++) {
- _whenStatements.add(arguments.get(i));
- }
- for (int i = numWhenStatements; i < numWhenStatements * 2; i++) {
- _thenStatements.add(arguments.get(i));
- }
- if (arguments.size() % 2 != 0 &&
!isNullLiteralTransformation(arguments.get(arguments.size() - 1))) {
- _elseStatement = arguments.get(arguments.size() - 1);
- }
- }
-
private TransformResultMetadata calculateResultMetadata() {
DataType dataType;
if (_elseStatement == null) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
