gortiz opened a new pull request, #11670: URL: https://github.com/apache/pinot/pull/11670
The reason to be of this PR is to be able to progress on https://github.com/apache/pinot/issues/11656. Spotless does not support Java 21 yet (see https://github.com/diffplug/spotless/pull/1822) so this PR moves the spotless usage to its own profile, which is active automatically if and only if the JVM being used is not 21. Once Spotless support Java 21 (probably when https://github.com/diffplug/spotless/pull/1822 is merged) we could just remove this profile and move the spotless config to the build->pluginManagement section. # Why don't just disable spotless with `-Dspotless.skip`? IT would be a great, but spotless doesn't work in that way. Even with that property set, spotless actually executes. What the flag controls is whether the pipeline should fail or not if spotless detects an issue in the code (like importing something that is not being used). When using Java 21, spotless throws an exception that is not caught, so it always aborts the maven execution, even if `-Dspotless.skip` is set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
