tibrewalpratik17 commented on issue #11658: URL: https://github.com/apache/pinot/issues/11658#issuecomment-1733518875
@Jackie-Jiang we see that this exists but while trying to use other storage dbs, we had to copy-paste a lot of code from `ConcurrentMapPartitionUpsertMetadataManager` just to change the storage layer. We realised having a storage-based interface makes it more flexible as we don't need to do any overhead maintenance of changes happening in `ConcurrentMapPartitionUpsertMetadataManager` and just implement `ConcurrentMap` interface. We essentially want the `addRecord`, `updateRecord` logic to be same in our case as well. What we are interested in is changing the underlying storage for `_primaryKeyToRecordLocationMap.put`, `_primaryKeyToRecordLocationMap.remove`... calls and writing the entire `ConcurrentMapPartitionUpsertMetadataManager` again seems like an overkill. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
