xiangfu0 commented on code in PR #11669:
URL: https://github.com/apache/pinot/pull/11669#discussion_r1336264697
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -574,17 +577,17 @@ public static void
addColumnMetadataInfo(PropertiesConfiguration properties, Str
}
public static void addColumnMinMaxValueInfo(PropertiesConfiguration
properties, String column, String minValue,
- String maxValue, DataType dataType) {
- properties.setProperty(getKeyFor(column, MIN_VALUE),
getValidPropertyValue(minValue, false, dataType));
- properties.setProperty(getKeyFor(column, MAX_VALUE),
getValidPropertyValue(maxValue, true, dataType));
+ String maxValue, DataType storedType) {
+ properties.setProperty(getKeyFor(column, MIN_VALUE),
getValidPropertyValue(minValue, false, storedType));
+ properties.setProperty(getKeyFor(column, MAX_VALUE),
getValidPropertyValue(maxValue, true, storedType));
}
/**
* Helper method to get the valid value for setting min/max.
*/
- private static String getValidPropertyValue(String value, boolean isMax,
DataType dataType) {
- String valueWithinLengthLimit = getValueWithinLengthLimit(value, isMax,
dataType);
- return dataType.getStoredType() == DataType.STRING
+ private static String getValidPropertyValue(String value, boolean isMax,
DataType storedType) {
+ String valueWithinLengthLimit = getValueWithinLengthLimit(value, isMax,
storedType);
+ return storedType.getStoredType() == DataType.STRING
Review Comment:
`storedType == DataType.STRING`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
