swaminathanmanish opened a new pull request, #11682: URL: https://github.com/apache/pinot/pull/11682
**Problem**: hasOptionalKeyword has been deprecated due to which protobuf null handling was also not working correctly. PR that marked it deprecated https://github.com/protocolbuffers/protobuf/commit/d6157f7c7ec78a6942cfd6d96d2e0b40e007ae0d We use isOptional() instead that checks only the field LABEL ` /** Is this field declared optional? */ public boolean isOptional() { return proto.getLabel() == FieldDescriptorProto.Label.LABEL_OPTIONAL; }` Reference - https://github.com/protocolbuffers/protobuf/blob/d6157f7c7ec78a6942cfd6d96d2e0b40e007ae0d/java/core/src/main/java/com/google/protobuf/Descriptors.java **Test:** Ingested Kafka protobuf stream that has defaults and verified that they are treated as nulls through query (attached image) <img width="1728" alt="Screenshot 2023-09-25 at 2 06 30 PM" src="https://github.com/apache/pinot/assets/126024920/d2bc4324-57cc-4c57-9b8b-6633bae5b6db";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
