Jackie-Jiang commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1336515237
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##########
@@ -106,8 +106,11 @@ private void addFlattenedRecords(List<Map<String, String>>
records) {
// Put both key and key-value into the posting list. Key is useful for
checking if a key exists in the json.
String key = entry.getKey();
_postingListMap.computeIfAbsent(key, k -> new
RoaringBitmap()).add(_nextFlattenedDocId);
- String keyValue = key + JsonIndexCreator.KEY_VALUE_SEPARATOR +
entry.getValue();
- _postingListMap.computeIfAbsent(keyValue, k -> new
RoaringBitmap()).add(_nextFlattenedDocId);
+ int length = _jsonIndexConfig.getMaxValueLength();
Review Comment:
@chenboat I totally understand the intention, and I agree we can make the
longest allowed value configurable. I'm proposing saving even more space when
the value is longer than the threshold by not storing the value at all because
it is not queryable anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
