swaminathanmanish commented on code in PR #11682:
URL: https://github.com/apache/pinot/pull/11682#discussion_r1337725975
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordExtractorTest.java:
##########
@@ -166,7 +166,7 @@ private Map<String, Object> createRecord1() {
record.put(LONG_FIELD, 100L);
record.put(DOUBLE_FIELD, 1.1);
record.put(FLOAT_FIELD, 2.2f);
- record.put(BOOL_FIELD, "false");
+ record.put(BOOL_FIELD, "true");
Review Comment:
We already have tests for that. I've added comments to the tests that
verifies that explicitly set optional field values are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
