swaminathanmanish commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1340683133
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java:
##########
@@ -65,6 +65,7 @@ public class SegmentGenerationTaskRunner implements
Serializable {
public static final String DEPRECATED_USE_LOCAL_DIRECTORY_SEQUENCE_ID =
"local.directory.sequence.id";
public static final String USE_GLOBAL_DIRECTORY_SEQUENCE_ID =
"use.global.directory.sequence.id";
public static final String APPEND_UUID_TO_SEGMENT_NAME =
"append.uuid.to.segment.name";
+ public static final String OMIT_TIMESTAMPS_IN_SEGMENT_NAME =
"omit.timestamps.in.segment.name";
Review Comment:
The change looks good otherwise.
Can we rename to "**append.timestamps.to.segment.name**", to be consistent
with how its done for uuid (append.uuid.to.segment.name). Also we creating the
name here, so might be intuitive to include/not include?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
