swaminathanmanish commented on code in PR #11712:
URL: https://github.com/apache/pinot/pull/11712#discussion_r1341419664
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordExtractor.java:
##########
@@ -62,7 +62,7 @@ private Object getFieldValue(Descriptors.FieldDescriptor
fieldDescriptor, Messag
// Note w.r.t proto3 - If a field is not declared with optional keyword,
there's no way to distinguish
// if its explicitly set to a proto default or not been set at all i.e
hasField() returns false
// and we would use null.
- if (fieldDescriptor.isRepeated() || !fieldDescriptor.isOptional() ||
message.hasField(fieldDescriptor)) {
+ if (fieldDescriptor.isRepeated() || !fieldDescriptor.hasOptionalKeyword()
|| message.hasField(fieldDescriptor)) {
Review Comment:
This is exactly what my PR changed - from hasOptionalKeyword to isOptional
https://github.com/apache/pinot/pull/11682
API is deprecated
https://github.com/protocolbuffers/protobuf/commit/d6157f7c7ec78a6942cfd6d96d2e0b40e007ae0d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
