Jackie-Jiang commented on code in PR #11715:
URL: https://github.com/apache/pinot/pull/11715#discussion_r1341915681
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -48,15 +48,12 @@ public static void setExecutionStatistics(BaseResultsBlock
resultsBlock, List<Op
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
- // TODO: Check all operators and properly implement the getIndexSegment
and remove this exception handling
Review Comment:
Don't remove this TODO. This TODO is the correct thing to do, and we should
ensure all the top level operator (e.g. Select, Aggregation, GroupBy) has this
method implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
