dang-stripe commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1343182535
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java:
##########
@@ -134,13 +135,15 @@ private SegmentNameGenerator
getSegmentNameGenerator(SegmentGeneratorConfig segm
boolean appendUUIDToSegmentName =
Boolean.parseBoolean(segmentNameGeneratorConfigs.get(APPEND_UUID_TO_SEGMENT_NAME));
+ boolean excludeTimestampsInSegmentName =
Review Comment:
does it make sense to add to the `NormalizedDateSegmentNameGenerator`
though? it's specifically used for human-readable data strings in the segment
name and the flag would remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
