vvivekiyer commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1343207940
##########
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##########
@@ -168,6 +169,19 @@ protected byte[]
processQueryAndSerialize(ServerQueryRequest queryRequest, Execu
byte[] responseBytes = serializeResponse(queryRequest, instanceResponse);
+ Map<String, String> queryOptions =
queryRequest.getQueryContext().getQueryOptions();
+ Long maxResponseByteLength =
QueryOptionsUtils.getMaxSerializedResponseLengthPerServer(queryOptions);
+ if (maxResponseByteLength != null && responseBytes.length >
maxResponseByteLength) {
+ String errorMessage = String.format("Serialized response exceeds
threshold for requestId %d from broker %s",
+ queryRequest.getRequestId(), queryRequest.getBrokerId());
+ LOGGER.error(errorMessage);
+ // TODO(Vivek): Add a metric indicating the number of such exceptions.
+ instanceResponse = new InstanceResponseBlock();
+
instanceResponse.addException(QueryException.getException(QueryException.INTERNAL_ERROR,
errorMessage));
Review Comment:
Good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
