walterddr commented on code in PR #11726:
URL: https://github.com/apache/pinot/pull/11726#discussion_r1344574540
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -70,25 +70,27 @@ public enum TransformFunctionType {
// predicate functions
EQUALS("equals"),
- NOT_EQUALS("not_equals"),
- GREATER_THAN("greater_than"),
- GREATER_THAN_OR_EQUAL("greater_than_or_equal"),
+ NOT_EQUALS("not_equals", "notEquals"),
Review Comment:
So 2 options. Either we allow underscore on both scalar and transform. Or we
don't allow them in neither.
Problem is that transform function in v1 allows underscore so for backward
compatibility we need to register them. It is not about syntax.
For syntax sake we should not allow underscore format all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
