mayankshriv commented on code in PR #11753:
URL: https://github.com/apache/pinot/pull/11753#discussion_r1348752471
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufConfluentSchemaTest.java:
##########
@@ -94,8 +103,16 @@ public void testSamplePinotConsumer()
ConsumerRecords<byte[], byte[]> consumerRecords =
kafkaConsumer.poll(Duration.ofMillis(1000));
Iterator<ConsumerRecord<byte[], byte[]>> iter = consumerRecords.iterator();
+ Consumer<Message> onMessage = message -> {
+ // we use this to verify we are not creating/consuming modified
descriptors
+ // older versions of confluent connectors (7.1.x and lower) used to
rewrite proto3 optional as oneof at descriptor
+ // level. Newer versions of confluent consumers support both
alternatives.
+ Descriptors.FieldDescriptor optionalField =
message.getDescriptorForType().findFieldByName("optionalField");
+ Assert.assertNull(optionalField.getRealContainingOneof(), "Received
protobuf have been rewritten");
Review Comment:
Should this be added as a check during table creation?
##########
pom.xml:
##########
@@ -168,7 +168,7 @@
<argLine>-Xms4g -Xmx4g</argLine>
<protobuf.version>3.24.3</protobuf.version>
<grpc.version>1.53.0</grpc.version>
- <confluent.version>5.5.3</confluent.version>
+ <confluent.version>7.4.0</confluent.version>
Review Comment:
This is a huge jump in version, do we know what else could it impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
