dserfe opened a new pull request, #11771: URL: https://github.com/apache/pinot/pull/11771
This PR is to fix a flaky test `org.apache.pinot.core.operator.filter.NotFilterOperatorTest#testNotOperator` in `pinot-core`. ## Test failures - Run the following commands to reproduce test failures: ``` mvn -pl pinot-core edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.pinot.core.operator.filter.NotFilterOperatorTest#testNotOperator ``` - Then we get the following failures: ``` java.lang.AssertionError: expected [14] but found [0] ``` ## Root cause and fix In line 38, `expectedResult` is defined as a `HashSet`, which does not guarantee the orders of its elements, so in line 46, when iterating the elements of a `HashSet`, the elements returned are not in a consistent order, which leads to test failures. To fix the flakiness, use `LinkedHashSet` instead of `HashSet`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
