klsince commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1355861888


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -137,6 +139,23 @@ public static String createUniqueRebalanceJobIdentifier() {
   }
 
   public RebalanceResult rebalance(TableConfig tableConfig, RebalanceConfig 
rebalanceConfig) {
+    long startTime = System.currentTimeMillis();
+    String tableNameWithType = tableConfig.getTableName();
+    String status = "ABORTED";

Review Comment:
   right, this was for uncaught exceptions. I thought about `unknown`, but 
`errored` seems better. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to