tibrewalpratik17 commented on code in PR #11811:
URL: https://github.com/apache/pinot/pull/11811#discussion_r1361135179
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -535,6 +537,13 @@ public GenericRow updateRecord(GenericRow record,
RecordInfo recordInfo) {
protected abstract GenericRow doUpdateRecord(GenericRow record, RecordInfo
recordInfo);
+ @Override
+ public boolean shouldDropRecord(RecordInfo recordInfo) {
+ return doShouldDropRecord(recordInfo);
Review Comment:
> how about to move the changes from L307-L326 in
ConcurrentMapPartitionUpsertMetadataManager to this shouldDropRecord() method
@klsince `ConcurrentMapPartitionUpsertMetadataManager` tries to access the
ConcurrentHashMap for previous record for comparing comparison values. We will
not have access to that HashMap here.
> add a handleOutOfOrderEvent method in base class
We already have a `handleOutOfOrderEvent` method in base class just below
this method which updates metrics.
Let me know if I am missing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
