swaminathanmanish commented on code in PR #11832:
URL: https://github.com/apache/pinot/pull/11832#discussion_r1364669982
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -805,21 +805,26 @@ public List<String> getSegmentsFor(String
tableNameWithType, boolean shouldExclu
IdealState idealState = getTableIdealState(tableNameWithType);
Preconditions.checkState(idealState != null, "Failed to find ideal state
for table: %s", tableNameWithType);
List<String> segments = new ArrayList<>(idealState.getPartitionSet());
- if (startTimestamp == Long.MIN_VALUE && endTimestamp == Long.MAX_VALUE) {
- return shouldExcludeReplacedSegments ?
excludeReplacedSegments(tableNameWithType, segments) : segments;
- } else {
- List<String> selectedSegments = new ArrayList<>();
- List<SegmentZKMetadata> segmentZKMetadataList =
getSegmentsZKMetadata(tableNameWithType);
- for (SegmentZKMetadata segmentZKMetadata : segmentZKMetadataList) {
- String segmentName = segmentZKMetadata.getSegmentName();
- if (segments.contains(segmentName) &&
isSegmentWithinTimeStamps(segmentZKMetadata, startTimestamp, endTimestamp,
- excludeOverlapping)) {
+ List<SegmentZKMetadata> segmentZKMetadataList =
getSegmentsZKMetadata(tableNameWithType);
+ List<String> selectedSegments = new ArrayList<>();
+ for (SegmentZKMetadata segmentZKMetadata : segmentZKMetadataList) {
+ String segmentName = segmentZKMetadata.getSegmentName();
+ // Compute the interesction of segmentZK metadata and idealstate for
valid segmnets
+ if (!segments.contains(segmentName)) {
Review Comment:
Could you add log indicating that ideal state is different from Segment ZK
metadata and which segments they are ? This will have to be fixed manually?
LGTM otherwise. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
