gortiz commented on code in PR #11858:
URL: https://github.com/apache/pinot/pull/11858#discussion_r1369087047
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -391,12 +391,12 @@ private void handleTransientStreamErrors(Exception e)
_serverMetrics.addMeteredTableValue(_tableStreamName,
ServerMeter.REALTIME_CONSUMPTION_EXCEPTIONS,
1L);
if (_consecutiveErrorCount > MAX_CONSECUTIVE_ERROR_COUNT) {
- _segmentLogger.warn("Stream transient exception when fetching messages,
stopping consumption after {} attempts",
- _consecutiveErrorCount, e);
+ _segmentLogger.warn("Stream transient exception when fetching messages,
stopping consumption after "
+ + _consecutiveErrorCount + " attempts", e);
throw e;
} else {
- _segmentLogger
- .warn("Stream transient exception when fetching messages, retrying
(count={})", _consecutiveErrorCount, e);
+ _segmentLogger.warn("Stream transient exception when fetching messages,
retrying (count="
+ + _consecutiveErrorCount + ")", e);
Review Comment:
This was incorrect. We were calling `Logger.warn(String, Object..)`, which
AFAIK doesn't treat the exception in any specific way.
Instead with the change we call `Logger.warn(String, Throwable)`, which does
treat the throwable as an special argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
