soumitra-st commented on code in PR #11859:
URL: https://github.com/apache/pinot/pull/11859#discussion_r1372412303
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -729,6 +729,24 @@ public List<String> getAllOfflineTables() {
return offlineTableNames;
}
+ /**
+ * Get all dimension table names.
+ *
+ * @return List of dimension table names
+ */
+ public List<String> getAllDimensionTables() {
+ List<String> dimensionTableNames = new ArrayList<>();
+ for (String resourceName : getAllResources()) {
+ if (TableNameBuilder.isOfflineTableResource(resourceName)) {
+ final TableConfig tableConfig = getTableConfig(resourceName);
Review Comment:
This will provide users easy way to get the list of dimension tables,
instead of getting all the configs and filtering them. Changed the code to use
TableCache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
