snleee commented on code in PR #11887:
URL: https://github.com/apache/pinot/pull/11887#discussion_r1373918171


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##########
@@ -69,12 +70,22 @@ public class CompositeTransformer implements 
RecordTransformer {
    *   </li>
    * </ul>
    */
-  public static CompositeTransformer getDefaultTransformer(TableConfig 
tableConfig, Schema schema) {

Review Comment:
   Let's keep this function to be backward compatible. I feel that there will 
be code bases that will break from this change. We can add new functions for 
the new requirement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to