walterddr commented on code in PR #11885:
URL: https://github.com/apache/pinot/pull/11885#discussion_r1374834351
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java:
##########
@@ -128,6 +128,8 @@ public PlanNode visitExchange(ExchangeNode node, Context
context) {
}
int currentPlanFragmentId = context._previousPlanFragmentId;
int nextPlanFragmentId = ++context._currentPlanFragmentId;
+ // Set previous PlanFragment ID in the context to be the next PlanFragment
ID to be used by the child node.
+ context._previousPlanFragmentId = nextPlanFragmentId;
Review Comment:
this might be more clear:
```suggestion
// for exchange node: visiting the next node effectively breaks the plan
into 2 parts and thus there's no definition
// of _previousPlanFragmentId for the next planFragmentRoot: thus
setting both Ids to the nextPlanFragmentId as a start
context._currentPlanFragmentId = context._previousPlanFragmentId =
nextPlanFragmentId;```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
