walterddr commented on code in PR #11911:
URL: https://github.com/apache/pinot/pull/11911#discussion_r1377694473
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -181,9 +181,15 @@ public ControllerRequestClient
getControllerRequestClient() {
return _controllerRequestClient;
}
+ public void startDefaultTestZk() {
Review Comment:
who is using this new method?
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -181,9 +181,15 @@ public ControllerRequestClient
getControllerRequestClient() {
return _controllerRequestClient;
}
+ public void startDefaultTestZk() {
+ if (_zookeeperInstance == null) {
+ _zookeeperInstance =
ZkStarter.startLocalZkServer(ZkStarter.DEFAULT_ZK_TEST_PORT);
+ }
+ }
+
public void startZk() {
if (_zookeeperInstance == null) {
- _zookeeperInstance = ZkStarter.startLocalZkServer();
+ _zookeeperInstance =
ZkStarter.startLocalZkServer(NetUtils.findOpenPort(20000 +
RandomUtils.nextInt(10000)));
Review Comment:
any specific reason to find a port between 20000 and 30000?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
