walterddr commented on issue #11272:
URL: https://github.com/apache/pinot/issues/11272#issuecomment-1799751110
here is just my opinion
1. either approach seems fine to me. subtree omit will be more verbose
(print multiple lines); and all sending host on same line will make the line
longer; it's really an aesthetic choice
- however if we ever decided to have different subtree, it will be
difficult to print
- the above is highly unlikely and even if there is, there should be
only differences based on physical properties such as one subtree on hostA has
2 segments and hostB has 0 segments and thus being optimized into a empty
response.
2. mailbox send/receive should share indentation IMO b/c they technically
are one exchange node
3. we should list all column types and reference names
- but we can also do disable/enable via option, this is not a
requirement IMO
4. operand reference is much better b/c it tells the relationship between
adjacent nodes (e.g PROJECT[$2(STRING), $5(INT)] tells that the 2nd and 5th
columns are read out from previous node's output)
- however, operator, such as function names, should be parsed out (e.g.
$f1 is confusing)
Please definitely share your thoughts @ankitsultana @Jackie-Jiang @xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
