Jackie-Jiang commented on code in PR #11970:
URL: https://github.com/apache/pinot/pull/11970#discussion_r1386136995
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java:
##########
@@ -89,12 +92,23 @@ public ExecutionStatistics getExecutionStatistics() {
@Override
protected TransferableBlock getNextBlock() {
- // A blocking call to construct a set with all the right side rows.
- if (!_isRightSetBuilt) {
- constructRightBlockSet();
+ try {
+ if (_isTerminated) {
+ return TransferableBlockUtils.getEndOfStreamTransferableBlock();
+ }
+ if (!_isRightSetBuilt) {
+ // construct a SET with all the right side rows.
+ constructRightBlockSet();
+ }
+ if (_upstreamErrorBlock != null) {
Review Comment:
We probably don't need to save this as member variable. Also, the error from
right table is not gathered
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -132,25 +132,22 @@ public String toExplainString() {
@Override
protected TransferableBlock getNextBlock() {
try {
Review Comment:
Do we always need to do this try-catch? Consider moving it into base class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
