Jackie-Jiang commented on code in PR #12000:
URL: https://github.com/apache/pinot/pull/12000#discussion_r1395006387
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1531,9 +1530,10 @@ public PauseStatus pauseConsumption(String
tableNameWithType) {
IdealState updatedIdealState =
updatePauseStatusInIdealState(tableNameWithType, true);
Set<String> consumingSegments = findConsumingSegments(updatedIdealState);
sendForceCommitMessageToServers(tableNameWithType, consumingSegments);
- return new PauseStatus(true, consumingSegments,
consumingSegments.isEmpty() ? null : "Pause flag is set."
- + " Consuming segments are being committed."
- + " Use /pauseStatus endpoint in a few moments to check if all
consuming segments have been committed.");
+ _controllerMetrics.setValueOfTableGauge(tableNameWithType,
ControllerGauge.TABLE_CONSUMPTION_PAUSED, 1);
Review Comment:
This won't capture the paused table when controller is restarted. We need to
set this gauge when a segment commits, or in `ensureAllPartitionsConsuming()`
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -871,8 +872,8 @@ public void ensureAllPartitionsConsuming(TableConfig
tableConfig, StreamConfig s
boolean offsetsHaveToChange = offsetCriteria != null;
if (isTableEnabled && !isTablePaused) {
List<PartitionGroupConsumptionStatus>
currentPartitionGroupConsumptionStatusList =
- offsetsHaveToChange
- ? Collections.emptyList() // offsets from metadata are not
valid anymore; fetch for all partitions
+ offsetsHaveToChange ? Collections.emptyList()
Review Comment:
(minor) This is not as readable. Suggest not reformatting unrelated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
