jadami10 commented on code in PR #11943:
URL: https://github.com/apache/pinot/pull/11943#discussion_r1397778891
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMetadataProvider.java:
##########
@@ -43,6 +45,18 @@ public interface StreamMetadataProvider extends Closeable {
*/
int fetchPartitionCount(long timeoutMillis);
+ /**
+ * Fetches the partition ids for a topic given the stream configs.
+ */
+ default Set<Integer> fetchPartitionIds(long timeoutMillis) {
Review Comment:
should we still use `fetchStreamPartitionOffset` as the default? this will
break anyone upgrading with custom stream ingestion unless they can perfectly
coordinate plugin deploys with new pinot deploys.
in our case, we could do it. But plugins live in a separate repo, so it
would take a fair bit of coordination to get the latest libraries, update the
plugin, deploy both server and plugin, and make sure nothing restarts in the
middle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
