itschrispeck commented on code in PR #12017:
URL: https://github.com/apache/pinot/pull/12017#discussion_r1402706477
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java:
##########
@@ -1035,6 +1036,13 @@ public void testUploadToSegmentStore()
// Verify the result
segmentManager.uploadToDeepStoreIfMissing(segmentManager._tableConfig,
segmentsZKMetadata);
+
+ // Block until all tasks have been able to complete
+ ThreadPoolExecutor deepStoreUploadExecutor =
segmentManager.getDeepStoreUploadExecutor();
+ while (deepStoreUploadExecutor.getActiveCount() > 0) {
Review Comment:
Changed to use pending segment set size, as waiting on downloadUrl makes it
difficult to correctly test the error cases where we assert downloadUrl isn't
set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
