KKcorps opened a new pull request, #12050: URL: https://github.com/apache/pinot/pull/12050
Whenever we reach a fetchTimeout In PulsarConsumer, we can run into an issue whereby we use `forEach` on the messages list to read the data while also simultaneously adding data to the list. This happens irregularly because there can be a small delay when we send the `cancel` signal to the executor vs when the task is actually cancelled. The end result is a `ConcurrentModificationException` The solution is to use a synchronisedList in place of vanilla array list to ensure thread safe execution. Another solution can be to ensure the executor gets shutdown completely before triggering `forEach`. However there's no hard time limit on how long can executor take to stop which is why I didn't take this approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
