vvivekiyer commented on issue #12078:
URL: https://github.com/apache/pinot/issues/12078#issuecomment-1836933120

   @richardstartin 
   We did try the GC optimizations with -XX:+UseStringDeduplication but noticed 
elevated CPU usage affecting our query latencies. 
   
   I want to clarify that we are not using Java's native `string.intern()` here 
but rather using manual interning. As I shared above, the implementation is 
based on article [here]( 
https://dzone.com/articles/duplicate-strings-how-to-get-rid-of-them-and-save). 
The Poc code is available here - 
https://github.com/vvivekiyer/pinot/commit/dc4538bd88f050c20f8dd17530d0e38052b92c65
 .
   
   Do you see any potential issues mentioned in the article based on the code 
above? I'll also take a closer look at the article you shared. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to