mcvsubbu commented on code in PR #12088:
URL: https://github.com/apache/pinot/pull/12088#discussion_r1414249251
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1559,12 +1560,54 @@ private boolean isTmpAndCanDelete(URI uri, Set<String>
deepURIs, PinotFS pinotFS
/**
* Force commit the current segments in consuming state and restart
consumption
+ * Commit all partitions unless either partitionsToCommit or
segmentsToCommit are provided.
+ *
+ * @param tableNameWithType table name with type
+ * @param partitionsToCommit comma separated list of partitions to commit
+ * @param segmentsToCommit comma separated list of consuming segments to
commit
+ * @return the set of consuming segments that were committed
Review Comment:
We really don't wait for them to commit, so perhaps we should say something
like:
"set of segments for which commit was initiated"
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1559,12 +1560,54 @@ private boolean isTmpAndCanDelete(URI uri, Set<String>
deepURIs, PinotFS pinotFS
/**
* Force commit the current segments in consuming state and restart
consumption
+ * Commit all partitions unless either partitionsToCommit or
segmentsToCommit are provided.
+ *
+ * @param tableNameWithType table name with type
+ * @param partitionsToCommit comma separated list of partitions to commit
Review Comment:
To be consistent, should it be "partitionGroupIdsToCommit" instead of
"partitionsToCommit"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
