Jackie-Jiang commented on issue #12057: URL: https://github.com/apache/pinot/issues/12057#issuecomment-1839235972
This is a great optimization! There is another way to think about this problem. Since the partition info is maintained on the broker side, and broker needs to ensure all segments for the same partition are served by the same server, I'd suggest letting broker handle this optimization by leveraging the query option `serverReturnFinalResult` introduced in #9304. There is no need to change the `AggregationFunction`, and we can make broker splitting the segments into per-partition segments and ask server to directly return the final result. When introducing the query option, I've considered using it for this optimization, but haven't got the time to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
