KKcorps commented on code in PR #12068:
URL: https://github.com/apache/pinot/pull/12068#discussion_r1415640982
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -52,45 +56,50 @@ public class PulsarConfig {
private final SubscriptionInitialPosition _subscriptionInitialPosition;
private final String _authenticationToken;
private final String _tlsTrustCertsFilePath;
+
+ private final String _issuerUrl;
+ private final String _credentialsFilePath; // Absolute path of your
downloaded key file
Review Comment:
How will someone provide this file in pinot deployments? I think if it's
running in docker, expecting folks to copy the credentials file to docker
volumn is wrong choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
