abhioncbr commented on code in PR #11985:
URL: https://github.com/apache/pinot/pull/11985#discussion_r1420619096
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##########
@@ -47,100 +47,77 @@ public class CommonsConfigurationUtils {
private CommonsConfigurationUtils() {
}
- public static void setListDelimiterHandler(PropertiesConfiguration
configuration, Character delimiter) {
- configuration.setListDelimiterHandler(new
DefaultListDelimiterHandler(delimiter));
+ /**
+ * Instantiate a {@link PropertiesConfiguration} from a {@link File}.
+ * @param file containing properties
+ * @return a {@link PropertiesConfiguration} instance. Empty if file does
not exist.
+ */
+ public static PropertiesConfiguration fromFile(File file) {
+ try {
+ return fromFile(file, false, false);
+ } catch (ConfigurationException e) {
Review Comment:
Sure, previously, these functions were throwing the Runtime exception. It
requires handling several places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
